London | Nadarajah_Sripathmanathan | book -library | Module-Data-Flows #178
Conversation
|
hi, |
sripathman
added
the
Needs Review
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
I think there are some improvements you can make.
There was a problem hiding this comment.
When I checked the code in index.html at https://validator.w3.org/, it indicated some errors.
There was a problem hiding this comment.
In terms of input validation,
- Are all input properly checked?
- Can
.valuebenull? (Do we need to checksomeInputElement.value == null?) - What if a user enters only space characters in the "title" input field?
- What if a users enters
-1or3.1416in the "pages" input field?
With the way the book's title is assigned to an HTML element, a book with a title containing special character sequence such as <i> can possibly ruin the display.
debugging/book-library/script.js
Outdated
| for (let n = rowsNumber - 1; n > 0; n--) { | ||
| table.deleteRow(n); | ||
| } |
There was a problem hiding this comment.
Instead of deleting the table rows one by one, can you think of a more efficient way to remove all rows (except the <th>...</th>) in the table?
debugging/book-library/script.js
Outdated
| alert(`You've deleted title: ${myLibrary[i].title}`); | ||
| myLibrary.splice(i, 1); |
There was a problem hiding this comment.
At the moment when the alert message is displayed, has the book mentioned in the message been deleted yet?
How would you rearrange these statements to make the message truthful?
cjyuan
added
Reviewed
sripathman
added
the
Complete
cjyuan
removed
the
Complete
|
I do not see any changes made to the files. I am removing the "Complete" label for now. |
sripathman
added
the
Complete
|
My feedback was not fully responded. |
cjyuan
removed
the
Complete
sripathman
added
the
Complete
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Changes look good.
Would be better if you can make this branch clean so that it only contains the two modified files that belong to the Book Library task.
| if (titleValue.length === 0) { | ||
| alert("Title cannot be just spaces!"); | ||
| return; | ||
| } |
| } | ||
|
|
||
| const pagesNumber = parseInt(pagesValue, 10); | ||
| if (isNaN(pagesNumber) || pagesNumber < 1 || !Number.isInteger(pagesNumber)) { |
There was a problem hiding this comment.
You were using parseInt(). Why further check if pagesNumber is integer?
|
|
||
| changeReadButton.addEventListener("click", function () { | ||
| myLibrary[i].read = !myLibrary[i].read; | ||
| changeReadButton.textContent = myLibrary[i].read ? "Yes" : "No"; |
There was a problem hiding this comment.
Could also consider calling render() to update the view to avoid maintaining two sets of code to update view.
4 participants
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.